feat: add triggerable exit flow #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add locator into WithdrawalVault
TheDZhon
reviewed
Apr 1, 2024
contracts/0.8.9/WithdrawalVault.sol
Outdated
| receive() external payable {} | ||
|
|
||
| function forcedExit(bytes[] calldata pubkeys, address sender) external payable { | ||
| if (msg.sender != address(getLocator().validatorsExitBusOracle())) { |
There was a problem hiding this comment.
so we don't allow this method to be called by the DAO directly?
There was a problem hiding this comment.
yes, DAO should send the report hash first for 2 reasons:
- exit more than 600 per/report
- depends on the
exitFee- can reverts early
TheDZhon
reviewed
Apr 2, 2024
contracts/0.8.9/WithdrawalVault.sol
Outdated
| uint256 vaultBalance = address(this).balance - msg.value; | ||
| uint256 fee = msg.value; | ||
|
|
||
| uint256 keysCount = pubkeys.length; |
There was a problem hiding this comment.
should check if non zero and isn't too large both
There was a problem hiding this comment.
we check it in VEBO contract here
| _saveReportData(reportHash, requestsCount); | ||
| } | ||
|
|
||
| function forcedExitPubkeys(bytes[] calldata keys, ReportData calldata data) external payable { |
There was a problem hiding this comment.
yes - its a permissionless part
Co-authored-by: Eugene Mamin <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Code Coverage SummaryDiff against masterResults for commit: 8a77a87 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
tamtamchik
added
contracts
|
Closed as ported to lidofinance/lido-dao#859 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.